Skip to content

Conversation

@kensave
Copy link
Contributor

@kensave kensave commented May 11, 2025

Add a new semantic_search_client crate that provides vector embedding and
semantic search capabilities for the Amazon Q CLI. This implementation:

- Supports text embedding generation using Candle and ONNX runtimes
- Provides hardware acceleration via Metal on macOS
- Implements efficient vector indexing for semantic search
- Includes file processing utilities for various file types
- Supports persistent storage of semantic contexts
- Includes comprehensive test coverage

This crate will enable memory bank functionality for Amazon Q, allowing
users to create, manage, and search through semantic memory contexts.

🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@06b1bfb). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage        ?   16.75%           
=======================================
  Files           ?      213           
  Lines           ?    20704           
  Branches        ?      871           
=======================================
  Hits            ?     3468           
  Misses          ?    17236           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kensave kensave force-pushed the kensave/semantic_crate_merge branch from 44550be to c27c609 Compare May 12, 2025 22:08
…mbedding and

    semantic search capabilities for the Amazon Q CLI. This implementation:

    - Supports text embedding generation using Candle and ONNX runtimes
    - Provides hardware acceleration via Metal on macOS
    - Implements efficient vector indexing for semantic search
    - Includes file processing utilities for various file types
    - Supports persistent storage of semantic contexts
    - Includes comprehensive test coverage

    This crate will enable memory bank functionality for Amazon Q, allowing
    users to create, manage, and search through semantic memory contexts.

    🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
@kensave kensave force-pushed the kensave/semantic_crate_merge branch from c27c609 to e59abdc Compare May 12, 2025 22:33
@kensave kensave self-assigned this May 12, 2025
…ects

This change modifies the semantic search client to use Box<dyn TextEmbedderTrait>
on Linux platforms instead of directly using CandleTextEmbedder. This provides
more flexibility and consistency with the implementation on macOS and Windows,
allowing for better extensibility and polymorphic behavior across all platforms.
@chaynabors chaynabors merged commit 029f760 into aws:main May 13, 2025
11 checks passed
brandonskiser added a commit that referenced this pull request May 14, 2025
chaynabors pushed a commit that referenced this pull request May 14, 2025
This was referenced May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants